Frontend send success #3118
Open
Frontend send success #3118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The backend either returns success true or false plus aborted, or false with errorMessage and optional errorCode.
The view component already has a success icon, this adds a
Only render sendResult if available and do not cover.
Adds done and continue buttons to send result view instead of showing the success/error for 5 seconds.
So it can be called after send result
So it can be reused in send or sendresult.
thisconnect
force-pushed
the
frontend-send-success
branch
from
ba5ec85 to
d1e7d07
Compare
- show errors in send result view instead of popups - add edit transaction if there was an error - add new transaction on success - add buy ETH if there was gasfeetoolow error
thisconnect
force-pushed
the
frontend-send-success
branch
from
d1e7d07 to
8fb23cc
Compare
thisconnect
commented
Jan 14, 2025
| @@ -494,7 +500,6 @@ class Send extends Component<Props, State> { | |||
| coinCode={account.coinCode} | |||
| transactionDetails={waitDialogTransactionDetails} | |||
| /> | |||
| <SendResult result={sendResult} /> | |||
There was a problem hiding this comment.
I am not sure if we should do this commit, it changes the behavior as it prevents the other components from being rendered, especially FeeTargets or CoinContorl UTXOs component.
This could lead to problems when there was an error and the user goes back, the selected UTXO's in the subcomponent might not be selected anymore
I think it is cleaner this way, but it is not requierd.. need to do more testing.
thisconnect
requested review from
shonsirsha and
benma
and removed request for
benma
thisconnect
commented
Jan 14, 2025
| </span> | ||
| </p> | ||
| {(proposedAmount && proposedAmount.conversions && proposedAmount.conversions[activeCurrency]) ? ( | ||
| <FiatValue baseCurrencyUnit={activeCurrency} amount={proposedAmount.conversions[activeCurrency] || ''} /> |
There was a problem hiding this comment.
this should probably have an estimation sign unless it is a coin/token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.