Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: hide estimate sign if conversion is btc or sat #3119

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

thisconnect
Copy link
Collaborator

Until a transaction has 6 confirmations we do show a estimation sign for the conversion amount as the exact time is still not final.

The user can optionally choose BTC or sat as conversion unit in these cases no estimation sign is needed.

@thisconnect
Copy link
Collaborator Author

with this commit:

should show estimate sign for Fiat conversion currencies:
Screenshot 2025-01-09 at 16 36 57

but not for if conversion currency is BTC or sat:
Screenshot 2025-01-09 at 16 36 48

Copy link
Collaborator

@sutterseba sutterseba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested LGTM with typo nit

frontends/web/src/components/transactions/transaction.tsx Outdated Show resolved Hide resolved
Until a transaction has 6 confirmations we do show a estimation sign
for the conversion amount as the exact time is still not final.

The user can optionally choose BTC or sat as conversion unit in
these cases no estimation sign is needed.
@thisconnect thisconnect force-pushed the frontend-hide-estimate branch from afd8d93 to 090038f Compare January 14, 2025 14:39
@thisconnect thisconnect merged commit 72bb074 into BitBoxSwiss:master Jan 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants