-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deps): vendor babylonlabs-io-btc-staking-ts module #5698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OttoAllmendinger
commented
Mar 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to verify that the vendored is correct, run this script
npx ts-node scripts/vendor-github-repo.ts vendor --name btc-staking-ts
3bd02d4
to
5a0b7ba
Compare
modules/babylonlabs-io-btc-staking-ts/tests/staking/createSlashingTx.test.ts
Fixed
Show fixed
Hide fixed
modules/babylonlabs-io-btc-staking-ts/tests/staking/createSlashingTx.test.ts
Fixed
Show fixed
Hide fixed
modules/babylonlabs-io-btc-staking-ts/tests/staking/createSlashingTx.test.ts
Fixed
Show fixed
Hide fixed
modules/babylonlabs-io-btc-staking-ts/tests/staking/createSlashingTx.test.ts
Fixed
Show fixed
Hide fixed
modules/babylonlabs-io-btc-staking-ts/tests/staking/createWithdrawTx.test.ts
Fixed
Show fixed
Hide fixed
modules/babylonlabs-io-btc-staking-ts/tests/staking/stakingScript.test.ts
Fixed
Show fixed
Hide fixed
modules/babylonlabs-io-btc-staking-ts/tests/staking/transactions/withdrawTransaction.test.ts
Fixed
Show fixed
Hide fixed
modules/babylonlabs-io-btc-staking-ts/tests/utils/utxo/getPsbtInputFields.test.ts
Fixed
Show fixed
Hide fixed
c67c356
to
305704f
Compare
Adds script to vendor external github repositories into BitGoJS. Uses tar and fetch APIs to download and extract source code. Issue: BTC-1826
Add babylonlabs-io-btc-staking-ts to ignored paths to prevent linting and formatting of vendored code. Issue: BTC-1826
The upstream version has some challenges that make it difficult to use in our project: - poor commonjs support - overly restrictive node version Vendoring allows us to make the necessary changes in an easy way Issue: BTC-1826
Removed unused configuration files from vendored module. Simplifies maintenance and reduces potential conflicts. Issue: BTC-1826
Simple update of readme to indicate this is a BitGo fork of the original babylonlabs-io/btc-staking-ts project. Issue: BTC-1826
- updates package.json for BitGo namespace - relaxes node version requirements - fixes CommonJS typings generation - fix versions of bitcoinjs-lib and bip174 - remove test and lint scripts Issue: BTC-1826
Expose the Staking class and staking utils for external use. Retry-Counter: 1 Issue: BTC-1826
305704f
to
7539dc6
Compare
therealdwright
previously approved these changes
Mar 6, 2025
OttoAllmendinger
commented
Mar 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me get rid of these as well
Remove GitHub workflow files and Husky pre-commit hook from vendored package Issue: BTC-1826
sijuu
approved these changes
Mar 6, 2025
lcovar
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add babylonlabs BTC staking module as vendored dependency. Update package
configuration for BitGo use and expose staking functionality. Clean up
vendored code and add proper configuration.
Main changes:
Issue: BTC-1826