Implement WebSocket to Stream Silent Blocks #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theanmolsharma
requested changes
Sep 28, 2024
There was a problem hiding this comment.
A few more thoughts:
- I see that you are injecting
SilentBlocksGatewayintoSilentBlocksService. That is not the standard pattern. Gateways are like Controllers. You don't inject controllers into a service, you inject service into a controller. Therefore, please remove the event handling logic fromSilentBlocksServiceand move it to inside ofSilentBlocksGateway. - I also think we should use
socket.ioand leverage the concept of rooms. Once a client connects to use, we can subscribe them to aSILENT_BLOCKroom. Then we just need to publish silent block to that room and let socket.io handle it from there. This will eliminate the need offorEachloop inbroadcastSilentBlock
|
Okay, changes noted |
theanmolsharma
requested changes
Oct 16, 2024
|
Please Rebase From main |
Okay |
seekersoftec
force-pushed
the
silent-blocks-websockets
branch
4 times, most recently
from
3f0b282 to
4caad8e
Compare
seekersoftec
force-pushed
the
silent-blocks-websockets
branch
2 times, most recently
from
0bb8e57 to
30ba463
Compare
aruokhai
suggested changes
Oct 30, 2024
seekersoftec
force-pushed
the
silent-blocks-websockets
branch
3 times, most recently
from
ff08e74 to
6817e37
Compare
theanmolsharma
previously approved these changes
Nov 26, 2024
theanmolsharma
requested changes
Nov 26, 2024
seekersoftec
force-pushed
the
silent-blocks-websockets
branch
2 times, most recently
from
d1c939c to
24f3a27
Compare
fixed event emitter issue fix: Add a delay function for silent block events fix: silent block broadcasting Fix: Use a more explicit event name for indexing blocks feat: implement silent block broadcasting fix: Make event emitter protected feat: implement silent block broadcasting fix: Add event emitter and gateway dependencies to tests chore: added makerfile to make local e2e test a breeze added makerfile to make local e2e test a breeze: working improved maker file structure with output logs for debug purpose chore: update vulnerable dependancies Signed-off-by: Anmol Sharma <[email protected]> feat: implement silent block broadcasting fixed event emitter issue fix: Add a delay function for silent block events fix: silent block broadcasting Fix: Use a more explicit event name for indexing blocks feat: implement silent block broadcasting fix: Make event emitter protected feat: implement silent block broadcasting fix: Add event emitter and gateway dependencies to tests fix: clean block provider module Fixes duplicate pm2 dependency and updates packages and Removes unused delay function from common.ts. fix: Remove delay in block processing
seekersoftec
force-pushed
the
silent-blocks-websockets
branch
from
24f3a27 to
7a1aa8e
Compare
|
Fixed all requested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective(s):
Implement a WebSocket connection to stream silent blocks to the client whenever a new block is found and indexed. This will eliminate the need for the client to keep polling for new blocks.
Changes:
wslibrary.base-block-data-provider.abstract.tsthat emits an event whenever a new block is indexed.SilentBlocksServiceand trigger the silent block broadcasting logic when the event is fired.Scope of Change:
This change is semi-critical. While it doesn't directly affect core functionality, it significantly enhances the user experience and system efficiency by providing real-time updates.
solves #45