End to End test #47
Merged
End to End test #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notTanveer
force-pushed
the
feature/e2e-test
branch
from
b4c2a11 to
7ff1fb5
Compare
aruokhai
reviewed
Sep 28, 2024
notTanveer
force-pushed
the
feature/e2e-test
branch
2 times, most recently
from
b7aa40e to
dfc3154
Compare
notTanveer
force-pushed
the
feature/e2e-test
branch
from
036847e to
09fcedd
Compare
notTanveer
force-pushed
the
feature/e2e-test
branch
from
09fcedd to
9d80c95
Compare
aruokhai
reviewed
Oct 8, 2024
notTanveer
force-pushed
the
feature/e2e-test
branch
3 times, most recently
from
15cd163 to
a6d07ef
Compare
aruokhai
reviewed
Oct 9, 2024
theanmolsharma
requested changes
Oct 9, 2024
notTanveer
force-pushed
the
feature/e2e-test
branch
2 times, most recently
from
260f2f0 to
9057cad
Compare
theanmolsharma
requested changes
Oct 12, 2024
notTanveer
force-pushed
the
feature/e2e-test
branch
from
f8f9012 to
c007524
Compare
theanmolsharma
requested changes
Oct 13, 2024
notTanveer
force-pushed
the
feature/e2e-test
branch
3 times, most recently
from
ba1a280 to
fa9a95a
Compare
theanmolsharma
requested changes
Oct 14, 2024
notTanveer
force-pushed
the
feature/e2e-test
branch
5 times, most recently
from
5b18309 to
3681f57
Compare
theanmolsharma
requested changes
Oct 17, 2024
There was a problem hiding this comment.
I see that you removed some useful comments from this file, please add them back
notTanveer
force-pushed
the
feature/e2e-test
branch
from
3681f57 to
861eef8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an end-to-end test for silent payments, ensuring that a crafted transaction sending 5.99 BTC to a Taproot address (with a 0.01 BTC fee) is correctly included in the silent block. The test compares the crafted transaction’s txid, output value, and scan tweak against the decoded silent block retrieved from the API (/silent-block/hash/{blockHash}). This ensures the transaction was successfully broadcast, mined, and that the correct amount was sent to the intended address.