Improved e2e Test setup #52
Conversation
aruokhai
force-pushed
the
improved_e2e
branch
from
5ae8d07 to
740e22b
Compare
aruokhai
force-pushed
the
improved_e2e
branch
6 times, most recently
from
f340962 to
7894fa7
Compare
aruokhai
force-pushed
the
improved_e2e
branch
from
7894fa7 to
117e0f6
Compare
aruokhai
force-pushed
the
improved_e2e
branch
from
117e0f6 to
5d4d964
Compare
aruokhai
force-pushed
the
improved_e2e
branch
from
5d4d964 to
b56a0cb
Compare
aruokhai
force-pushed
the
improved_e2e
branch
from
b56a0cb to
e3a16c3
Compare
e2e/setup.ts
Outdated
| stderr: true, | ||
| }); | ||
| logs.on('data', (log) => { | ||
| logger.log(log.toString()); |
There was a problem hiding this comment.
Log only essential information, such as errors or failed cases. Avoid excessive logging, as it would require sifting through unnecessary logs to identify failed test cases.
There was a problem hiding this comment.
Yes, that is quite true that bitcoind has excessive info, setting bitcoind env variable debug=0 still doesn't solve it, one way i believe to solve it is to not output debug info for indexer, @theanmolsharma , what do you think.
There was a problem hiding this comment.
Why can't we just write the stream to a file like .logs/bitcoind.log? and then in Github Actions, we can do cat .log/bitcoind.log
There was a problem hiding this comment.
The logging issue persists. What if we add a separate dropdown specifically for logs? @theanmolsharma
aruokhai
force-pushed
the
improved_e2e
branch
7 times, most recently
from
016999d to
bd000da
Compare
aruokhai
force-pushed
the
improved_e2e
branch
from
bd000da to
3b87fd2
Compare
Draft: Improved E2E Test implemented improved e2e test structure
aruokhai
force-pushed
the
improved_e2e
branch
from
3b87fd2 to
5c87696
Compare
There was a problem hiding this comment.
ACK 5c87696
This PR will be a big improvement. Thank you for putting so much effort into this.
Improved E2E test setup