Add Support for P2PKH and P2SH-P2WPKH Address Types #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aruokhai
reviewed
Nov 18, 2024
aruokhai
reviewed
Nov 18, 2024
aruokhai
suggested changes
Nov 18, 2024
aruokhai
reviewed
Nov 18, 2024
aruokhai
reviewed
Nov 18, 2024
notTanveer
force-pushed
the
feature/address-types
branch
8 times, most recently
from
6c16999 to
8d6bf7c
Compare
Draft: Improved E2E Test implemented improved e2e test structure
notTanveer
force-pushed
the
feature/address-types
branch
2 times, most recently
from
c14897a to
5583fc1
Compare
theanmolsharma
requested changes
Nov 27, 2024
notTanveer
force-pushed
the
feature/address-types
branch
from
70f9a62 to
ce30905
Compare
|
Why did you close this? |
merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for testing P2PKH and P2SH-P2WPKH address types in the indexer, ensuring silent blocks are correctly processed and retrieved for these transaction types. The test suite has been refactored improving maintainability and extending compatibility with diverse Bitcoin address types.