Introduce benching and improve add_blocks by 45%
#101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using criterion so that we don't need nightly to run benchmark. The "bench" features is also introduced as a way to bench private methods via public methods feature gated via this feature.
on my machine:
add_blocks time: [4.7562 ms 4.7754 ms 4.7972 ms]
change: [-15.059% -14.650% -14.169%] (p = 0.00 < 0.05)
Performance has improved.
add_blocks time: [3.9458 ms 3.9586 ms 3.9717 ms]
change: [-17.564% -17.103% -16.660%] (p = 0.00 < 0.05)
Performance has improved.
add_blocks time: [2.9788 ms 2.9938 ms 3.0101 ms]
change: [-24.810% -24.373% -23.897%] (p = 0.00 < 0.05)
Performance has improved.
|
Woah very nice! Impressive gains for so little change. :) |
shesek
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduce benching via criterion so that performance changes can be measured.
Criterion is used so that nightly is not required to run benchmarks and also has a nice change report.
The bench feature is introduced to expose to benching private functions, otherwise unreachable from the
benchesdir.After setting up benchmark for the
add_blocks3 commits avoiding to recompute txids in various places gave a cumulative performance improvement of 45%