Batching with array #108
Batching with array #108
Conversation
|
Should we limit the number of requests per batch? |
| @@ -137,3 +140,44 @@ fn test_electrum() -> Result<()> { | |||
|
|
|||
| Ok(()) | |||
| } | |||
|
|
|||
| /// Test the Electrum RPC server using an headless Electrum wallet | |||
There was a problem hiding this comment.
The comment here should be updated, "using a raw TCP socket" or something similar
Do we have limits for "new-line separated" batch requests? Is it different here? How much do you propose as the limit here? |
We don't, but it is different here. New-lines separated requests are streamed, and individual responses are sent as they become available. We only hold up to 10 pending requests in the queue, then block and stop reading from the TCP socket until a pending request gets processed to free room (a bounded With array batching all the requests and all the response has to be buffered in-memory at once, which could use significant resources and be a DoS vector if there are no limits in place. |
Do you think we can afford 20 as the limit for batch requests? I think it's common number because is used as gap limit... |
|
20 seems fine, yes 👍 However it seems the tests are failing. The failure isn't directly related to the batching but to the TestRunner used to test it. |
RCasatta
force-pushed
the
batching_with_array
branch
from
0bd3299
to
d08cf38
Compare
At the moment we cannot concurrently tests because the server will conflict with each other, this make the test_electrum_raw test ignored by default, and add a test in CI specifically for this test.
|
I didn't realize locally because i launched the test singularly, I think we don't support having multiple concurrent tests. |
Currently electrs support batching by separating requests via new lines, however, other impls support it also via json array as explained in the cited issue. This add support for batching requests via json array
close Blockstream/esplora#516