Python investigation renames #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python/example.py
Outdated
| @@ -101,7 +101,7 @@ async def participant( | |||
| state2, eq_round1 = participant_step2(hostseckey, state1, cmsg1) | |||
| except UnknownFaultyParticipantOrCoordinatorError as e: | |||
| if blame_mode: | |||
There was a problem hiding this comment.
investigation_mode?
python/example.py
Outdated
| @@ -129,7 +129,7 @@ async def coordinator( | |||
| # If the coordinator implements blame mode and it is enabled, it sends an | |||
| # extra message to the participants. | |||
| if blame_mode: | |||
| blame_msgs = coordinator_blame(pmsgs1) | |||
| blame_msgs = coordinator_investigate(pmsgs1) | |||
There was a problem hiding this comment.
Suggested change
| blame_msgs = coordinator_investigate(pmsgs1) | |
| inv_msgs = coordinator_investigate(pmsgs1) |
python/tests.py
Outdated
| @@ -249,10 +249,10 @@ def simulate_chilldkg( | |||
| def simulate_chilldkg_full( | |||
| hostseckeys, | |||
| t, | |||
| blame: bool, | |||
| investigation: bool, | |||
| ) -> List[Optional[Tuple[chilldkg.DKGOutput, chilldkg.RecoveryData]]]: | |||
| # blaming is not supported by this wrapper | |||
There was a problem hiding this comment.
Suggested change
| # blaming is not supported by this wrapper | |
| # Investigating is not supported by this wrapper |
python/chilldkg_ref/encpedpop.py
Outdated
| ) -> NoReturn: | ||
| simpl_blame_state, enc_secshare, pads = blame_state | ||
| enc_partial_secshares, partial_pubshares = cblame | ||
| simpl_blame_state, enc_secshare, pads = error.blame_state |
There was a problem hiding this comment.
Suggested change
| simpl_blame_state, enc_secshare, pads = error.blame_state | |
| simpl_invstate, enc_secshare, pads = error.invstate |
python/chilldkg_ref/chilldkg.py
Outdated
| cblame: CoordinatorBlameMsg, | ||
| def participant_investigate( | ||
| error: UnknownFaultyParticipantOrCoordinatorError, | ||
| cinvestigation: CoordinatorInvestigationMsg, |
There was a problem hiding this comment.
I think we can use a short form "inv" in variable names (everywhere):
Suggested change
| cinvestigation: CoordinatorInvestigationMsg, | |
| cinv: CoordinatorInvestigationMsg, |
5 tasks
jonasnick
force-pushed
the
python-investigation-renames
branch
from
fe66c7a to
23547a7
Compare
participant_blame -> participant_investigate coordinator_blame -> coordinator_investigate CoordinatorBlameMsg -> CoordinatorInvestigationMsg cblame -> cinv blame_mode -> investigation_mode blame_msg -> inv_msg Leaving the "blame state" to be fixed in the next commit.
jonasnick
force-pushed
the
python-investigation-renames
branch
from
23547a7 to
be83df9
Compare
|
First commit should be ready for review now. Still working on the second commit. |
jonasnick
force-pushed
the
python-investigation-renames
branch
from
be83df9 to
c3298c9
Compare
|
Ready for review now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.