Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust page scaling when following link to book (BL-14198) #351

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

JohnThomson
Copy link
Contributor

@JohnThomson JohnThomson commented Jan 14, 2025

This change is Reviewable

Copy link
Member

@hatton hatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @JohnThomson)


src/bloom-player-controls.tsx line 986 at r1 (raw file):

                    // follows a link to a different book, at which point we DO need to re-scale,
                    // since that book may use a different page size or orientation.
                    // So, do the rescale if there's been a previous notification and

If the URL changes within a second (e.g. e2e test), then we don't adjust? Should we say time OR URL change?

Copy link
Contributor Author

@JohnThomson JohnThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @hatton)


src/bloom-player-controls.tsx line 986 at r1 (raw file):

Previously, hatton (John Hatton) wrote…

If the URL changes within a second (e.g. e2e test), then we don't adjust? Should we say time OR URL change?

Don't need the time if we can tell that the URL changed. But that was internal to bloom-player-core. Reworked.

Copy link
Member

@hatton hatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @JohnThomson)

@hatton hatton merged commit 8b7e5d9 into master Jan 14, 2025
1 check was pending
@hatton hatton deleted the resizeFollowingLink branch January 14, 2025 23:58
Copy link

🎉 This PR is included in version 2.8.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants