Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement inverseTotient #142
Implement inverseTotient #142
Changes from 21 commits
e907fa8
a5c9027
88bde95
a2521f2
8a6a56e
a876370
04a4fba
752bb52
054d3f9
bdef230
20eed48
e24b4e1
769605d
b3b9622
bcad9ed
07f9047
4c0c305
5386ad0
27eda69
c3383ec
ceb94f1
076dfa3
b67bb41
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be nice to include examples of calculating the sum or sum of squares of preimages:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually
Sum
is redundant:inverseTotient id 120
works as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True! In that case, it might be nice to add a note saying that the semiring on Word is the one given by addition and multiplication, to explain why that works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do even something like
inverseTotient (sigma 1) 120
%)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL this how we define one valid semiring for the
min
operator, I wasn't quite sure(*)
would work.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I didn't give much importance to this before, but why was this
Maybe
before, and why change it now?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to me that switching to a newly defined sum type allows the non-infinite case to be more strict, since the indirection provided by
Just
is removedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Operations on
DirichletSeries
never force values of the underlyingMap
: all multiplications and filtering is based solely on keys. So values of theMap
inevitably accumulate huge thunks, unless a)Data.Map.Strict
is used, which triggers weak head normal form (WHNF) evaluation of values, b) datatype for values is strict, meaning that WHNF conicides with a normal form. This is crucial for a decent performance.Maybe a
type is lazy: forcing WHNF will force only evaluation ofJust
constructor, but not the value ofa
. On contraryMinNatural
is strict, thanks to bang.