Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc/v3.0.1 #12

Merged
merged 7 commits into from
Oct 8, 2024
Merged

Rc/v3.0.1 #12

merged 7 commits into from
Oct 8, 2024

Conversation

zsigmas
Copy link
Contributor

@zsigmas zsigmas commented Oct 7, 2024

Adresses: #8

Critical checks

  • Is the version number correct?

  • Does the build pass?


Documentation

Does it include the following sections?

  • Module introduction with features

    • (O) Screenshots
  • Installation details

  • Explanation of function arguments

  • Data specifications and requirements

  • Different possible visualizations

  • Are the changes/new features included in NEWS.md?

  • (O) Screenshots

  • (O) Explanation of input menus

  • (O) Short articles on building the app, compatibility with other modules, known bugs,...


QC Report

  • Does it include a QC Report?

API conventions

[ ] Follows API convention

@zsigmas zsigmas requested a review from a team as a code owner October 7, 2024 15:01
@zsigmas zsigmas linked an issue Oct 7, 2024 that may be closed by this pull request
ml-ebs-ext
ml-ebs-ext previously approved these changes Oct 7, 2024
Copy link

@ml-ebs-ext ml-ebs-ext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good (once you appease the styler) :(

Copy link

@ml-ebs-ext ml-ebs-ext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@zsigmas zsigmas merged commit 6da6da9 into main Oct 8, 2024
7 checks passed
@zsigmas zsigmas deleted the rc/v3.0.1 branch October 8, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rc dv.filter 3.0.1
2 participants