Prevent an uncaught exception warning in a test suite thread #635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted this while attempting to run the test suite locally with warnings enabled:
The easiest fix is to stop raising an exception in the mock. In addition, since
RuntimeError
may be raised in several ways, I added amatch
argument to thepytest.raises()
context manager to identify whichRuntimeError
text is expected.After avoiding that warning, a ResourceWarning popped up:
This happens because the underlying event loop (the one that is getting swapped out with a mock) is not getting closed.