Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage #154

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Fix coverage #154

merged 1 commit into from
Feb 6, 2024

Conversation

Bouni
Copy link
Owner

@Bouni Bouni commented Feb 6, 2024

Next attempt, this time I try what Chat GPT thinks is the right way of doing this

Copy link

github-actions bot commented Feb 6, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
luxtronik
   __init__.py14311023%39–55, 62–67, 70, 74–79, 84–88, 101–104, 111, 115, 119, 123, 134, 137–140, 143–163, 166–181, 184–201, 204–219, 223–225, 229–230, 234–235
   __main__.py21210%3–49
   datatypes.py2751296%38, 43, 48, 58, 73–76, 81–84, 93
   discover.py433421%26–78
luxtronik/scripts
   dump_changes.py44440%5–93
   dump_luxtronik.py28280%5–64
TOTAL63724961% 

Tests Skipped Failures Errors Time
116 4 💤 0 ❌ 0 🔥 0.664s ⏱️

@Bouni Bouni requested a review from gerw February 6, 2024 11:23
@Bouni
Copy link
Owner Author

Bouni commented Feb 6, 2024

@gerw Not sure if this does the trick. Would you mind doing another merge and rebase?

Copy link
Collaborator

@gerw gerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try.

@gerw gerw merged commit 2fe447b into main Feb 6, 2024
6 of 8 checks passed
@gerw
Copy link
Collaborator

gerw commented Feb 6, 2024

Nope. From my very little understanding, it seems that the git workflow is running in my repository (for a PR from my fork), and this does not have access to stuff from this repo (e.g., to GITHUB_TOKEN). But I might be wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants