Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two staged coverage comment attempt #156

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Two staged coverage comment attempt #156

merged 1 commit into from
Feb 7, 2024

Conversation

Bouni
Copy link
Owner

@Bouni Bouni commented Feb 7, 2024

This is a two staged approach to fix the permission problme when posting the coverage report on a PR that fomes from a forked repo.

Found here:

@Bouni Bouni requested a review from gerw February 7, 2024 12:02
@Bouni
Copy link
Owner Author

Bouni commented Feb 7, 2024

@gerw I think this could work but we will only see if you again merge this. I'm soory that this is such a pain but I also don't want to push to main directly ...

@gerw gerw merged commit 0c58586 into main Feb 7, 2024
6 of 8 checks passed
@gerw
Copy link
Collaborator

gerw commented Feb 7, 2024

The coverage workflow did not run in #150. Maybe we need the name Run unit tests and not the file name in

?

@Bouni
Copy link
Owner Author

Bouni commented Feb 7, 2024

I think you're right, I'll submit another PR in a few minutes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants