Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor discover function #184

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Refactor discover function #184

wants to merge 2 commits into from

Conversation

Bouni
Copy link
Owner

@Bouni Bouni commented Sep 23, 2024

As brought up in #73 the discover function was to large and cased ruff warnings.

This PR splits the discover function into smaller logical functions and adds unit tests

@Bouni Bouni requested a review from kbabioch September 23, 2024 07:45
@github-actions GitHub Actions
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
luxtronik
   __init__.py1841194%42–43, 46–51, 257–258, 263
   __main__.py21210%3–49
   datatypes.py276199%82
   discover.py58198%62
luxtronik/scripts
   dump_changes.py43430%7–85
   dump_luxtronik.py26260%6–52
TOTAL69410385% 

Tests Skipped Failures Errors Time
134 0 💤 0 ❌ 0 🔥 4.196s ⏱️

@Bouni Bouni linked an issue Sep 23, 2024 that may be closed by this pull request
Refactor and split discover function #73
Open
@Bouni Bouni requested a review from gerw November 1, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbabioch kbabioch Awaiting requested review from kbabioch

@gerw gerw Awaiting requested review from gerw

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor and split discover function
1 participant
@Bouni