Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX switchoff reasons #186

Merged
merged 1 commit into from
Nov 1, 2024
Merged

FIX switchoff reasons #186

merged 1 commit into from
Nov 1, 2024

Conversation

gerw
Copy link
Collaborator

@gerw gerw commented Oct 31, 2024

I tried to combine the strings displayed in the heat pump with the information from the manual. It also seems that the IDs 1, 2 and 4 were incorrect.

ID 24 LPC might translate to limit power consumption, but I am not sure. It is not mentioned in the manual.

Fixes #185

@gerw gerw force-pushed the switchoff_reasons branch from 79b0a5e to c50adb0 Compare October 31, 2024 12:11
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
luxtronik
   __init__.py1841194%42–43, 46–51, 257–258, 263
   __main__.py21210%3–49
   datatypes.py276199%82
   discover.py403415%21–69
luxtronik/scripts
   dump_changes.py43430%7–85
   dump_luxtronik.py26260%6–52
TOTAL67613680% 

Tests Skipped Failures Errors Time
124 0 💤 0 ❌ 0 🔥 4.005s ⏱️

@Guzz-T
Copy link
Contributor

Guzz-T commented Oct 31, 2024

LGTM

@Bouni Bouni self-requested a review November 1, 2024 08:51
@Bouni Bouni merged commit f5c48bf into Bouni:main Nov 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SwitchoffFile value '22' seems to be 'No request'
3 participants