feat(new reviewer): ignore display cutout

https://developer.android.com/develop/ui/views/layout/edge-to-edge#cutout-insets
BrayanDSO · Jun 30, 2024 · 168f7a5 · 168f7a5
1 parent 976507e
commit 168f7a5
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 1 deletion.
diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/ReviewerFragment.kt b/AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/ReviewerFragment.kt
@@ -54,6 +54,7 @@ import com.ichi2.anki.snackbar.SnackbarBuilder
 import com.ichi2.anki.snackbar.showSnackbar
 import com.ichi2.anki.utils.ext.collectIn
 import com.ichi2.anki.utils.ext.collectLatestIn
+import com.ichi2.anki.utils.ext.sharedPrefs
 import com.ichi2.anki.utils.navBarNeedsScrim
 import com.ichi2.libanki.sched.Counts
 import com.ichi2.utils.increaseHorizontalPaddingOfOverflowMenuIcons
@@ -318,8 +319,14 @@ class ReviewerFragment :
             systemBarsBehavior = WindowInsetsControllerCompat.BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE
         }
 
+        val ignoreDisplayCutout = sharedPrefs().getBoolean(getString(R.string.ignore_display_cutout_key), false)
         ViewCompat.setOnApplyWindowInsetsListener(view) { v, insets ->
-            val bars = insets.getInsets(WindowInsetsCompat.Type.systemBars())
+            val typeMask = if (ignoreDisplayCutout) {
+                WindowInsetsCompat.Type.systemBars()
+            } else {
+                WindowInsetsCompat.Type.systemBars() or WindowInsetsCompat.Type.displayCutout()
+            }
+            val bars = insets.getInsets(typeMask)
             v.updatePadding(
                 left = bars.left,
                 top = bars.top,

diff --git a/AnkiDroid/src/main/res/values/10-preferences.xml b/AnkiDroid/src/main/res/values/10-preferences.xml
@@ -442,4 +442,5 @@ this formatter is used if the bind only applies to both the question and the ans
         >Navigation bar</string>
     <string name="hide_system_bars_all_bars" comment="Setting option to hide all the system bars"
         >All</string>
+    <string name="ignore_display_cutout" maxLength="41">Ignore display cutout</string>
 </resources>
diff --git a/AnkiDroid/src/main/res/values/preferences.xml b/AnkiDroid/src/main/res/values/preferences.xml
@@ -202,4 +202,5 @@
 
     <!-- Reviewer options -->
     <string name="hide_system_bars_key">hideSystemBars</string>
+    <string name="ignore_display_cutout_key">ignoreDisplayCutout</string>
 </resources>
diff --git a/AnkiDroid/src/main/res/xml/preferences_reviewer.xml b/AnkiDroid/src/main/res/xml/preferences_reviewer.xml
@@ -9,4 +9,10 @@
         android:key="@string/hide_system_bars_key"
         android:title="@string/hide_system_bars"
         app:useSimpleSummaryProvider="true"/>
+
+    <SwitchPreferenceCompat
+        android:defaultValue="false"
+        android:key="@string/ignore_display_cutout_key"
+        android:title="@string/ignore_display_cutout"
+        />
 </androidx.preference.PreferenceScreen>