Permission screen #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Message to maintainers, this PR contains strings changes.
Read more about updating strings on the wiki, |
Use transparency to take account of the text background, so it isn't invisible in gray backgrounds
BrayanDSO
force-pushed
the
permission_screen
branch
from
778f4f7
to
5c87abf
Compare
Layout object that can be used to display a permission and get it. Ideally, it would use material components to deliver a better appearance, but we don't have material themes yet
BrayanDSO
force-pushed
the
permission_screen
branch
from
5c87abf
to
942f8bd
Compare
BrayanDSO
force-pushed
the
permission_screen
branch
2 times, most recently
from
32d855e
to
4dc705e
Compare
Using an enum to manage permissions has some advantages - can associate permissions with their screens - is exhaustive, so all permissions possibilities are known statically - is parcelable, so it can be passed as an activity extra, or a fragment argument AnkiDroidFolder is converted to a sealed class in order to handle permissionSets
Ideally, it would use material components to deliver a better appearance, but we don't have material themes yet
if all permissions have been granted
Simplifies things by not having to handle callbacks or blocking UI elements/background tasks while getting a permission. Also, it can be easily launched in other screens if necessary, which can avoid crashes like ankidroid#13518 Additionally, adds a better UI/UX for the user
got unused after permissions started being handled by permission screens With the new permission screens, the "Please grant AnkiDroid the 'All files access' permission to continue" string isn't necessary anymore
BrayanDSO
force-pushed
the
permission_screen
branch
from
4dc705e
to
5cb1ac5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Purpose / Description
Describe the problem or feature and motivation
Fixes
Fixes Link to the issues.
Approach
How does this change address the problem?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration (SDK version(s), emulator or physical, etc)
Learning (optional, can help others)
Describe the research stage
Links to blog posts, patterns, libraries or addons used to solve this problem
Checklist
Please, go through these checks before submitting the PR.