fix is_valid_description

Brushfam · Aug 15, 2023 · aaa0903 · aaa0903
1 parent a06db05
commit aaa0903
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/contracts/src/governance/governor/internal.rs b/contracts/src/governance/governor/internal.rs
@@ -252,7 +252,7 @@ pub trait GovernorInternal:
             return Ok(true)
         }
 
-        let pos = description.find("proposer=0x").unwrap();
+        let pos = description.find("proposer=0x").unwrap() + 11usize;
         let address = &description[pos..];
 
         if hex::decode(address).is_err() {

diff --git a/tests/e2e/governance/governor.tests.ts b/tests/e2e/governance/governor.tests.ts
@@ -717,6 +717,8 @@ describe('Governor', function () {
           '<description>#proposer=' + SS58ToHex(api, deployer.address)
         )
 
+        console.log(SS58ToHex(api, deployer.address))
+
         await expect(helper.propose(alice)).to.eventually.be.rejected
 
         await api.disconnect()

diff --git a/tests/e2e/governance/helper.ts b/tests/e2e/governance/helper.ts
@@ -48,10 +48,6 @@ export class GovernorHelper {
       throw new Error('Proposal not set')
     }
 
-    console.log('Proposal ID: ', await this.calculateProposalId())
-
-    console.log((await this.governor?.query.propose([this.proposal!], this.description!))?.value.ok?.err)
-
     if(proposer) {
       await this.governor?.withSigner(proposer).tx.propose([this.proposal!], this.description!)
     }