Convert history store #15408
Open
Convert history store #15408
+129
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
adrinr
commented
Jan 21, 2025
|
Dean already has a PR up for the screen store, so I'll let you 2 work out what's the best way to go haha. #15313 |
adrinr
force-pushed
the
BUDI-8986/convert-screen-store
branch
from
35ec347 to
15ffe58
Compare
|
@deanhannigan @aptkingston my PR also typed the history store. I resolved the conflicts after @deanhannigan's PR, so there is only the history store left |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converting history store to ts. This required some utils to be typed as well.