fix!: enoent searching for symbol files #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #108 BREAKING CHANGE: changes signature of public function uploadSymbolFiles
bobbyg603
changed the title
bobbyg603
changed the title
bobbyg603
changed the title
bobbyg603
force-pushed
the
bobbyg603/issue108
branch
from
6dffd6d to
b9b224e
Compare
daveplunkett
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some weird logic in here we use so that files with the same name but in different folders don't overwrite one another in the temp directory. To avoid this, we prefix the file name with the path to the file. Since 2 files with the same name can't be in the same folder this works because the prefix is always different, but it also gives us some idea where the symbol came from.
Fixes #108
BREAKING CHANGE: changes signature of public function uploadSymbolFiles