Fix uninstall #129
Merged
Fix uninstall #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhbyak
commented
Apr 19, 2024
zhbyak
commented
- 解决background和content加载不同步导致的通信异常问题
- 首次安装的时候，删除浏览器url中的xfans_token字段（会触发再次自动登录）
- 首次安装的时候，进行一次logout
huangbinjie
reviewed
Apr 19, 2024
| @@ -12,7 +12,6 @@ const manifest: ManifestV3Export = { | |||
| { | |||
| matches: ['https://twitter.com/*'], | |||
| js: ['src/content/index.tsx'], | |||
| run_at: 'document_end', | |||
There was a problem hiding this comment.
这个你不是要解决 interval handle resize 的问题的么，这里删了，那边又行了？
There was a problem hiding this comment.
这个document_end没有解决问题，实际还是过早，还是在load的事件里面处理
| @@ -58,3 +58,21 @@ async function withProxyStore(children: ReactElement, proxyStore: Store): Promis | |||
| return <Provider store={proxyStore}>{children}</Provider>; | |||
| }); | |||
| } | |||
|
|
|||
| // 监听来自 Background 脚本的消息 | |||
| chrome.runtime.onMessage.addListener((message, sender, sendResponse) => { | |||
There was a problem hiding this comment.
嗯 目前场景没有其他业务发送消息。
我加了一个消息下判断做了筛选
src/content/index.tsx
Outdated
| const url = new URL(window.location.href); // 获取当前URL | ||
| url.searchParams.delete(XFANS_TOKEN); // 删除指定的查询参数 | ||
| // 使用 history.replaceState 更新 URL | ||
| window.history.replaceState(null, '', url.toString()); |
| // 获取当前活动标签页 | ||
| const activeTab = tabs[0]; | ||
|
|
||
| if (activeTab) { |
There was a problem hiding this comment.
没问题 因为这个代码是插件加载成功之后，给background发消息，background做的回应。所以这个场景下twitter页面一定存在
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.