Parse and format player names with >1 comma #341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #316 and #214
This will produce:
Leno, Charles, Jr.'
->'Leno'
,'Charles Jr.'
name.split(',', 1)
-> only splits on the first occurrence of ',' ensuring not more than 2 itemss.strip().replace(',', '')
-> removes any remaining commas so that it doesn't affect CSVsThe other PRs would produce the following names:
#277:
'Leno'
,'Charles, Jr.'
#266:
'Leno'
,'Charles'
Regardless of which fix is best, one of these should really be merged.