Allow passing in sc2_version to all legacy host and launch methods #213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When launching SC2 in latest version, the minimap isn't clickable and buttons are greyed out for most users.
This behaviour started happening sometime during 5.0.x.
Everyone should be able to opt into launching v4.10.
Sharpy is currently held back, because the old launch methods (bot vs ai, bot vs bot) do not all allow passing in
sc2_version
.To demonstrate what this change does, if we were to update the example like
bot_vs_bot.py
where you play against yourself/custom scripted enemy:The added
sc2_version
param will now propagate through the legacy host- and join- commands.This obviously works for single-player (bot vs ai) too.
It is safe and does not interfere with the new launcher (run_multiple_games and GameMatch).
Omitting it launches the latest version as per usual.