Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Replaced typos in some images #29

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AmineAouragh
Copy link

This is a fix to the issue #24 that says that in the rest vs graphql picture there was a typo where 'Micorservices' should be 'Microservices'

Here is the current image used with the typo

graphQL (1)

and here is the image with the fixed typo

graphQL

@AmineAouragh
Copy link
Author

Fixed another typo signaled by issue #30 in the CI/CD Pipeline image.

Since i committed to my same branch fix-typo i couldn't create a new pull request so I am commenting here

@AmineAouragh AmineAouragh changed the title Fix: Typo in Rest vs GraphQL image Fix: Typo in Rest vs GraphQL image and CI/CD Pipeline (UPDATED) Oct 23, 2023
@AmineAouragh AmineAouragh changed the title Fix: Typo in Rest vs GraphQL image and CI/CD Pipeline (UPDATED) Fix: Replaced typos in some images Oct 23, 2023
@AmineAouragh
Copy link
Author

Fixed another typo signaled by issue #37 in the Monorepo vs Microrepo image

@salvadorgonmo
Copy link

Wondering, how do you usually fix typos on images? @ AmineAouragh

Just wondering how to do it so I can start my own contributions here as well.

Thanks!

@AmineAouragh
Copy link
Author

Hey @salvadorgonmo yeah sure

i use Canva to remove the typo and replace with a word, making sure to find the closest font possible to the one in the image

@matheusaraujo
Copy link

Nice work, @AmineAouragh! But, according to the CONTRIBUTING, I believe you should open an issue for fixing diagrams.

If you notice typos or issues in diagrams, please open a separate issue instead of fixing the images directly. We will update the source images and republish fixes.

https://github.com/ByteByteGoHq/system-design-101/blob/main/CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants