Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify computer for available data items #79

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

agoscinski
Copy link
Collaborator

Needs #78 to be merged before.

This allows to specify data items that are only remotely available or should not be copied over to the aiida internal folder. I did not add the computer information to the IR because the IR focuses on representing the unrolling/expansion from the config to a graph and the computer information is completely independent from this logic.

@leclairm
Copy link
Contributor

leclairm commented Jan 6, 2025

Same as for #78 , I'm fine with it but not an AiiDA expert so I let @GeigerJ2 and @DropD review it.

@agoscinski agoscinski force-pushed the computer branch 2 times, most recently from 2d5cfdb to 2508dd6 Compare January 9, 2025 15:49
@agoscinski agoscinski force-pushed the computer branch 2 times, most recently from df88aec to a385008 Compare January 9, 2025 17:02
Base automatically changed from computer to main January 9, 2025 17:43
This allows to specify data items that are only remotely available or
should not be copied over to the aiida internal folder. I did not add
the computer information to the IR because the IR focuses on
representing the unrolling/expansion from the config to a graph and the
computer information is completely independent from this logic.
@agoscinski
Copy link
Collaborator Author

@leclairm approved on slack

@agoscinski agoscinski merged commit 333baf7 into main Jan 9, 2025
3 checks passed
@agoscinski agoscinski deleted the remote-data branch January 9, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants