Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init vertical grid #470

Merged
merged 29 commits into from
Jul 8, 2024
Merged

Init vertical grid #470

merged 29 commits into from
Jul 8, 2024

Conversation

OngChia
Copy link
Contributor

@OngChia OngChia commented May 28, 2024

  1. Add vertical grid configuration, VerticalGridConfig, containing parameters that are used to initialize the vertical levels. Parameters in VerticalModelParams are derived from the configuration (except nflat_gradp, to be done in the future).
  2. Create a function in vertical.py to generate vct_a and vct_b either analytically or by reading from a file.
  3. Two data tests are created in test_vertical.py to check if computations of vct_a, vct_b , and nflatlev are correct : test_kflat_calculation and test_vct_a_vct_b_calculation_from_icon_input.
  4. The VerticalGridConfig is added to IconConfig as part of the initialization for the timeloop. Serialized data of vct_a and vct_b and nflatlev are no longer used.

@OngChia
Copy link
Contributor Author

OngChia commented May 28, 2024

cscs-ci run default

@OngChia
Copy link
Contributor Author

OngChia commented May 28, 2024

launch jenkins spack

@OngChia
Copy link
Contributor Author

OngChia commented May 28, 2024

cscs-ci run default

@OngChia
Copy link
Contributor Author

OngChia commented May 28, 2024

launch jenkins spack

@OngChia
Copy link
Contributor Author

OngChia commented May 28, 2024

cscs-ci run default

@OngChia
Copy link
Contributor Author

OngChia commented May 28, 2024

cscs-ci run default

@OngChia OngChia requested a review from halungge May 28, 2024 12:40
halungge
halungge requested changes Jun 12, 2024
View reviewed changes
model/common/src/icon4py/model/common/grid/base.py Show resolved Hide resolved
model/common/src/icon4py/model/common/grid/grid_manager.py Outdated Show resolved Hide resolved
model/common/src/icon4py/model/common/grid/vertical.py Outdated Show resolved Hide resolved
model/common/src/icon4py/model/common/grid/vertical.py Show resolved Hide resolved
model/common/src/icon4py/model/common/grid/vertical.py Outdated Show resolved Hide resolved
model/common/src/icon4py/model/common/grid/vertical.py Outdated Show resolved Hide resolved
model/common/src/icon4py/model/common/grid/vertical.py Outdated Show resolved Hide resolved
model/common/src/icon4py/model/common/grid/vertical.py Outdated Show resolved Hide resolved
model/common/src/icon4py/model/common/grid/vertical.py Show resolved Hide resolved
model/common/src/icon4py/model/common/grid/vertical.py Show resolved Hide resolved
@OngChia
Copy link
Contributor Author

OngChia commented Jun 21, 2024

cscs-ci run default

@OngChia
Copy link
Contributor Author

OngChia commented Jun 21, 2024

launch jenkins spack

@OngChia
Copy link
Contributor Author

OngChia commented Jun 21, 2024

cscs-ci run default

@OngChia OngChia requested a review from halungge June 26, 2024 07:03
@OngChia
Copy link
Contributor Author

OngChia commented Jun 26, 2024

cscs-ci run default

@OngChia
Copy link
Contributor Author

OngChia commented Jun 26, 2024

cscs-ci run default

@OngChia
Copy link
Contributor Author

OngChia commented Jul 2, 2024

cscs-ci run default

@OngChia
Copy link
Contributor Author

OngChia commented Jul 3, 2024

cscs-ci run default

@OngChia OngChia requested a review from halungge July 3, 2024 13:39
@OngChia
Copy link
Contributor Author

OngChia commented Jul 4, 2024

cscs-ci run default

@OngChia
Copy link
Contributor Author

OngChia commented Jul 4, 2024

cscs-ci run default

@OngChia
Copy link
Contributor Author

OngChia commented Jul 4, 2024

launch jenkins spack

@OngChia OngChia mentioned this pull request Jul 5, 2024
Merged
@OngChia
Copy link
Contributor Author

OngChia commented Jul 5, 2024

cscs-ci run default

@OngChia
Copy link
Contributor Author

OngChia commented Jul 5, 2024

launch jenkins spack

@OngChia
Copy link
Contributor Author

OngChia commented Jul 5, 2024

launch jenkins spack

@OngChia
Copy link
Contributor Author

OngChia commented Jul 5, 2024

cscs-ci run default

@OngChia
Copy link
Contributor Author

OngChia commented Jul 5, 2024

launch jenkins spack

@OngChia
Copy link
Contributor Author

OngChia commented Jul 5, 2024

cscs-ci run default

@OngChia
Copy link
Contributor Author

OngChia commented Jul 5, 2024

launch jenkins spack

@OngChia
Copy link
Contributor Author

OngChia commented Jul 5, 2024

cscs-ci run default

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • launch jenkins spack

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@OngChia
Copy link
Contributor Author

OngChia commented Jul 5, 2024

cscs-ci run default

@OngChia
Copy link
Contributor Author

OngChia commented Jul 6, 2024

launch jenkins spack

@OngChia OngChia merged commit dbdd899 into main Jul 8, 2024
4 of 5 checks passed
@samkellerhals samkellerhals deleted the init_vertical_grid branch December 20, 2024 08:37
OngChia added a commit that referenced this pull request Jan 14, 2025
@OngChia
Init vertical grid (#470)
a2c9152 
* create vertical grid config

* port completed.

* Clean up and modify data tests of granules and timeloop

* Fix bug from merge main

* precommit

* Fix bug after merge main

* Made changes according to review

* change diffusion

* Add xarray dependency

* add height index

* refine the vertical output

* fix typo

* remove xarray

* changes according to review

* change vertical grid initialization in diffusion wrapper

* nflat_gradp is added back in diffusion wrapper

* change long name of vct_a

* precommit run

* fix bugs due to change verticalGridParams
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halungge halungge halungge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OngChia @halungge