Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced module imports for dimensions #532

Merged
merged 19 commits into from
Sep 19, 2024
Merged

Conversation

nfarabullini
Copy link
Contributor

@nfarabullini nfarabullini commented Aug 27, 2024

removed local definition of dimensions and introduced module import -->

From:

# TODO: this will have to be removed once domain allows for imports
EdgeDim = dims.EdgeDim
KDim = dims.KDim

@field_operator
def _field_op(
	fields..,
        out=out,
        domain={
            EdgeDim: (horizontal_start, horizontal_end),
            KDim: (vertical_start, vertical_end),
        },
    )

To:

@field_operator
def _field_op(
	fields..,
        out=out,
        domain={
            dims.EdgeDim: (horizontal_start, horizontal_end),
            dims.KDim: (vertical_start, vertical_end),
        },
    )

@nfarabullini nfarabullini marked this pull request as draft August 27, 2024 08:03
@nfarabullini nfarabullini changed the title removed local definition of dimensions and introduced module import i… Introduced module imports for domain args Aug 27, 2024
@nfarabullini nfarabullini changed the title Introduced module imports for domain args Introduced module imports for dimensions Aug 27, 2024
Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • launch jenkins spack

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@nfarabullini
Copy link
Contributor Author

cscs-ci run default

@nfarabullini
Copy link
Contributor Author

launch jenkins spack

@nfarabullini nfarabullini marked this pull request as ready for review September 19, 2024 13:30
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note to myself: maybe in the future we could consider renaming the dimension symbols to drop the Dim suffix, since the name already contains dims in the module part...

@nfarabullini nfarabullini merged commit 0cd2670 into main Sep 19, 2024
5 checks passed
OngChia pushed a commit that referenced this pull request Jan 14, 2025
* removed local definition of dimensions and introduced module import in domain args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants