Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advection granule with horizontal transport #538

Merged
merged 50 commits into from
Oct 31, 2024
Merged

Add advection granule with horizontal transport #538

Show file tree
Hide file tree
Changes from 44 commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
8af170f
Add advection granule skeleton
Aug 15, 2024
1b0d5ed
Add first stencil call draft
Aug 15, 2024
790afb0
Add second-order accurate horizontal transport
Aug 26, 2024
dd2d98c
Make horizontal transport verify
Sep 2, 2024
c6c9982
Silence warnings and remove debug code
Sep 3, 2024
7ed12a0
Merge branch 'main' into advection_granule
Sep 3, 2024
ea74cd3
Adapt new code to main
Sep 3, 2024
d4b008e
Add proper advection test logging
Sep 3, 2024
6d44da4
Rename advection stencils
Sep 5, 2024
a5222d1
Modify highly generic advection stencils
Sep 5, 2024
6f0c732
Add missing python infrastructure files
Sep 5, 2024
234af2f
Remove dead stencil call
Sep 6, 2024
6d9470e
Add advection test CI
Sep 9, 2024
8691510
Merge branch 'main' into advection_granule
Sep 9, 2024
8285681
Adjust for variable precision in stencils
Sep 13, 2024
4175295
Merge branch 'main' into advection_granule
Sep 13, 2024
f614b23
Update AUTHORS.md
Sep 13, 2024
37f6678
Modify dimension imports wherever possible
Sep 13, 2024
4400b9d
Add start/end indices to all advection stencils
Sep 13, 2024
1812668
Perform simplifications on advection stencils
Sep 13, 2024
4fb7783
Apply suggestions from code review
dastrm Sep 16, 2024
8608a0f
Apply suggestions from code review
dastrm Sep 16, 2024
947505f
Fix remaining issues
Sep 16, 2024
4cc6a7f
Duplicate and simplify two stencils
Sep 18, 2024
a0f7581
Merge branch 'main' into advection_granule
Sep 18, 2024
4b55940
Add ntracer legend
Sep 18, 2024
84c2fef
Annotate advection stencils
Sep 18, 2024
b1f1876
Create horizontal and vertical advection classes
Sep 24, 2024
de7ff29
Merge branch 'main' into advection_granule
Sep 24, 2024
8d58173
Fix all advection imports
Oct 1, 2024
706d58c
Prepend underscore to private vars
Oct 1, 2024
1c0cb35
Set grid type and backend for all stencils
Oct 7, 2024
aa34f04
Organize code into more independent classes
Oct 10, 2024
6c17852
Fuse density increment stencils
Oct 10, 2024
d47d41f
Merge branch 'main' into advection_granule
Oct 10, 2024
a79fe17
Fix remaining issues
Oct 10, 2024
3edd923
Shorten advection class names
Oct 11, 2024
667315e
Separate tracer and numerical flux
Oct 14, 2024
0e55af3
Fix remaining issues
Oct 14, 2024
6304ba1
Remove excessive casting in stencils
Oct 17, 2024
48b1e8b
Merge branch 'main' into advection_granule
Oct 17, 2024
30f3d3a
Fix most of the failing stencil tests
Oct 21, 2024
8a99ca4
edits for offsets implementations
nfarabullini Oct 22, 2024
b747dd5
Make last stencil test pass
Oct 22, 2024
196a06b
Fix remaining advection issues
Oct 23, 2024
0c6ac7b
Merge branch 'main' into advection_granule
Oct 24, 2024
d7cec8f
Fix spack build
Oct 25, 2024
a7cfe0f
Merge branch 'main' into advection_granule
Oct 25, 2024
92aaf18
Introduce backend arguments in advection classes
Oct 25, 2024
3b26e4a
Remove backend from program decorators
Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,6 @@
- Paone, Edoardo. ETH Zurich - CSCS
- Röthlin, Matthias. MeteoSwiss
- Stellio, Mikael. MeteoSwiss
- Strassmann, David. ETH Zurich - EXCLAIM
- Vogt, Hannes. ETH Zurich - CSCS
- Weber, Benjamin. MeteoSwiss
2 changes: 1 addition & 1 deletion ci/default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ test_tools_aarch64:
- tox -r -e run_model_tests -c model/ -- --backend=$BACKEND $COMPONENT
parallel:
matrix:
- COMPONENT: [atmosphere/diffusion/tests/diffusion_tests, atmosphere/dycore/tests/dycore_tests, atmosphere/subgrid_scale_physics/microphysics/tests, common/tests, driver/tests]
- COMPONENT: [atmosphere/advection/tests/advection_tests atmosphere/diffusion/tests/diffusion_tests, atmosphere/dycore/tests/dycore_tests, atmosphere/subgrid_scale_physics/microphysics/tests, common/tests, driver/tests]
BACKEND: [gtfn_cpu]
test_model_datatests_x86_64:
extends: [.test_model_datatests, .test_template_x86_64]
Expand Down
Loading
Loading