-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test GTIR-DaCe backend #638
Draft
edopao
wants to merge
18
commits into
main
Choose a base branch
from
update_to_gtir_dace
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
cscs-ci run dace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Known issues:
concat_where
needed inTestFusedVelocityAdvectionStencil15To18
, test marked asxfail
atmosphere/advection
module, all stencil tests temporarily disabledBlocking issues:
test_fused_velocity_advection_stencil_1_to_7.py::TestFusedVelocityAdvectionStencil1To7::test_TestFusedVelocityAdvectionStencil1To7[backend=dace_gpu-grid=simple_grid] - ValueError: Missing symbols on nested SDFG "lambda_2: ['___tuple_el_14_size_1', '___tuple_el_14_stride_0', '___tuple_el_14_stride_1', '___tuple_el_14_size_0']"
test_fused_velocity_advection_stencil_8_to_13.py::TestFusedVelocityAdvectionStencil8To13::test_TestFusedVelocityAdvectionStencil8To13[backend=dace_gpu-grid=simple_grid] - ValueError: Failed to compute the inner strides.
test_compute_exner_from_rhotheta.py::TestComputeExnerFromRhotheta::test_TestComputeExnerFromRhotheta[backend=dace_gpu-grid=simple_grid] - AssertionError: Validation failed for 'theta_v'
tests/dycore_tests
(never tested before with dace backend)Depends on latest GT4Py main branch + lowering of scan PR (GridTools/gt4py#1776).