Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperating sensitive data through secret from being exposed #230

Open
wants to merge 1 commit into
base: stable
Choose a base branch
from

Conversation

bhanupriyanadendla
Copy link

@bhanupriyanadendla bhanupriyanadendla commented Jul 27, 2023

Description of the change

securing the sensitive data from exposing it to the user. This is the follow-up PR of actual docker image change which is in this PR https://github.gwd.broadcom.net/ESD/docker-gateway-base/pull/340/files.

Note: The PR raised on Docker-gateway-base should be reviewed and merged first before reviewing this PR. Otherwise this PR might cause failure of existing environment. So Please do not review this PR till the merge of Docker-gateway-base PR

Benefits

Drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

  • [] Chart version bumped in Chart.yaml according to semver.
  • [] Variables are documented in the README.md
  • [] Title of the PR starts with chart name (e.g. [charts/gateway])
  • [] If the chart contains a values-production.yaml apart from values.yaml, ensure that you implement the changes in both files

@Gazza7205 Gazza7205 self-requested a review July 27, 2023 09:24
Copy link
Contributor

@Gazza7205 Gazza7205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

env/fs changes should both be supported for backwards compatibility (this also requires an updated entrypoint which is not currently available on any of the base images).

I would keep the naming conventions the same vs. a env-secret which may be misleading. The difference is how they are referenced in the container gateway. One is envFrom and the other is a volume. A flag (default false) would be the least disruptive option.

Recommend using ct locally to resolve the lint errors. Charts are also versioned - the version field in Chart.yaml needs to be incremented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants