Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts/portal] Race condition - DE620051 #338

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Conversation

Gazza7205
Copy link
Contributor

@Gazza7205 Gazza7205 commented Nov 11, 2024

Description of the change

2.3.11 General Updates

  • Added a preflight check (initContainer) for the core apim/ingress deployment
    • This resolves a race condition that occurs on slower hardware where apim/ingress starts before other dependent services are ready.
    • This is enabled by default. A Helm upgrade will restart the apim deployment.
      • If you wish to disable this, set apim.preflightCheck.enabled to false
      apim:
        ...
        preflightCheck:
          enabled: true
        ...
      

Benefits

  • Portal can be successfully deployed on slower or shared hardware.

Drawbacks

  • Enabled by default meaning that the APIM container will be restarted on the initial Helm Upgrade.
  • There is always a minimum 120 second delay when deploying/replacing the APIM container

Applicable issues

  • DE620051

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [charts/gateway])
  • If the chart contains a values-production.yaml apart from values.yaml, ensure that you implement the changes in both files

Copy link
Contributor

@ksaladi ksaladi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Gazza7205 Gazza7205 merged commit 2e5206e into stable Nov 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants