Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[charts/portal] DE627635: add sync route back #353

Merged
merged 1 commit into from
Feb 11, 2025
Merged

[charts/portal] DE627635: add sync route back #353

merged 1 commit into from
Feb 11, 2025

Conversation

melil02
Copy link
Contributor

@melil02 melil02 commented Feb 11, 2025

Description of the change

added proper port mapping for sync route

Benefits

Drawbacks

Applicable issues

  • fixes #DE627635

Checklist

  • [*] Chart version bumped in Chart.yaml according to semver.
  • [*] Variables are documented in the README.md
  • [*] Title of the PR starts with chart name (e.g. [charts/gateway])
  • [*] If the chart contains a values-production.yaml apart from values.yaml, ensure that you implement the changes in both files

@melil02 melil02 requested a review from markgxchen February 11, 2025 20:09
markgxchen
markgxchen approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@markgxchen markgxchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markgxchen markgxchen merged commit cb5f6ec into develop/portal Feb 11, 2025
2 checks passed
@melil02 melil02 deleted the DE627635 branch February 11, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markgxchen markgxchen markgxchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@melil02 @markgxchen