Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor | CAKK-40 | BusinessInformation 관련 기능 이관 #188

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

lcomment
Copy link
Collaborator

Issue Number

CAKK-40

Description

BusinessInformation 관련 기능을 이관했습니다. 최근에 구현하신 어드민 기능입니다. 테스트 코드는 총 11개의 API가 모두 이관되면 작성 예정입니다.

etc

@lcomment lcomment added the refactor 비즈니스 변경 없는 수정 label Aug 16, 2024
@lcomment lcomment requested a review from YongsHub August 16, 2024 09:37
@lcomment lcomment self-assigned this Aug 16, 2024
Copy link

Test Results

198 tests   198 ✅  18s ⏱️
 34 suites    0 💤
 34 files      0 ❌

Results for commit 48f37fe.

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #188      +/-   ##
=============================================
- Coverage      89.86%   88.95%   -0.92%     
+ Complexity       332      329       -3     
=============================================
  Files            110      110              
  Lines            987      987              
  Branches          37       37              
=============================================
- Hits             887      878       -9     
- Misses            85       93       +8     
- Partials          15       16       +1     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2a38da...48f37fe. Read the comment docs.

Copy link
Contributor

@YongsHub YongsHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 새로 올린 PR에서 로직 리팩토링된게 있어서 rebase하시구 반영하고 머지하는게 편하실 것 같아요

@lcomment
Copy link
Collaborator Author

제가 새로 올린 PR에서 로직 리팩토링된게 있어서 rebase하시구 반영하고 머지하는게 편하실 것 같아요

나중에 리팩토링 사항 보고 반영하겠습니다.

@lcomment lcomment merged commit 5e74048 into develop Aug 18, 2024
3 checks passed
@lcomment lcomment deleted the refactor/CAKK-40 branch August 18, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 비즈니스 변경 없는 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants