Refactor | CAKK-95 | 의존성 관리 방식 관련 리팩토링 #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #226 +/- ##
==========================================
Coverage 90.19% 90.19%
Complexity 235 235
==========================================
Files 59 59
Lines 612 612
Branches 17 17
==========================================
Hits 552 552
Misses 51 51
Partials 9 9 Continue to review full report in Codecov by Sentry.
|
YongsHub
approved these changes
Dec 7, 2024
| @@ -49,7 +49,7 @@ class AppleAuthProviderTest : MockitoTest() { | |||
| val oidcPublicKeyList = fixtureMonkey.giveMeBuilder(OidcPublicKeyList::class.java) | |||
| .set("keys", Arbitraries.of(oidcPublicKeyFixture).list().ofMinSize(1).ofMaxSize(10)) | |||
| .sample() | |||
| val publicKey = fixtureMonkey.giveMeOne(PublicKey::class.java) | |||
| val publicKey = mock(PublicKey::class.java) | |||
There was a problem hiding this comment.
이거 mock Fixture 라이브러리 메서드인가요?
There was a problem hiding this comment.
네, mockito 메서드입니다.
public class MockitoCore {
. . .
public <T> T mock(Class<T> typeToMock, MockSettings settings) {
if (!(settings instanceof MockSettingsImpl)) {
throw new IllegalArgumentException(
"Unexpected implementation of '"
+ settings.getClass().getCanonicalName()
+ "'\n"
+ "At the moment, you cannot provide your own implementations of that class.");
}
MockSettingsImpl impl = (MockSettingsImpl) settings;
MockCreationSettings<T> creationSettings = impl.build(typeToMock);
checkDoNotMockAnnotation(creationSettings.getTypeToMock(), creationSettings);
T mock = createMock(creationSettings);
mockingProgress().mockingStarted(mock, creationSettings);
return mock;
}
. . .
}| "org.springframework.boot" -> useVersion(springBootVersion) | ||
| "io.spring.dependency-management" -> useVersion(springDependencyManagementVersion) | ||
| } | ||
| repositories { |
There was a problem hiding this comment.
dependencyResolutionManagement 역할이 뭔가요?
There was a problem hiding this comment.
블로그에 포스팅 했는데, 참고해주세요 ~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAKK-95
버전 관리를 편하게 하기 위해 의존성 관리 방식을 리팩토링 했습니다.
생략