Stoppage Criteria: max incorrect #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tab-cmd
approved these changes
Sep 26, 2024
bcipy/parameters/parameters.json
Outdated
| @@ -611,6 +611,14 @@ | |||
| "recommended_values": "", | |||
| "type": "int" | |||
| }, | |||
| "max_incorrect": { | |||
| "value": "3", | |||
There was a problem hiding this comment.
Let's set the default to five since that is the current norm for the clinical team
| @@ -94,7 +95,8 @@ class RSVPCopyPhraseTask(Task): | |||
| 'font', 'fixation_color', 'trigger_type', | |||
| 'filter_high', 'filter_low', 'filter_order', 'notch_filter_frequency', 'down_sampling_rate', 'prestim_length', | |||
| 'is_txt_stim', 'lm_backspace_prob', 'backspace_always_shown', | |||
| 'decision_threshold', 'max_inq_len', 'max_inq_per_series', 'max_minutes', 'max_selections', 'min_inq_len', | |||
| 'decision_threshold', 'max_inq_len', 'max_inq_per_series', 'max_minutes', 'max_selections', 'max_incorrect', | |||
There was a problem hiding this comment.
As a reminder to myself, we need to add this parameter to MatrixCopyPhrase in the orchestrator PR. I have since separated them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added stoppage criteria to copy phrase tasks to check for a given number of consecutive incorrect. This is set using a new parameter.
Ticket
https://www.pivotaltracker.com/story/show/188221684
Contributions
Test