Matrix Inquiry Preview #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to move some code to main module
… in Copy Phrase task which caused preview to be displayed twice. Updated demos and fixed unit tests
…ing inquiry preview
tab-cmd
approved these changes
Oct 7, 2024
| self.max_wait = max_wait | ||
| self.key_input = key_input | ||
| self.clock = clock or Clock() | ||
| self.response: Optional[List] = None |
There was a problem hiding this comment.
I think it would actually need to be something like Union[List[str], List[int]], which isn't quite right either. The problem is that a list is actually not a good representation of this data structure. It would make more sense to be a Tuple[str, float], which we do in some places. I made a cleanup ticket to address this across the code base: https://www.pivotaltracker.com/story/show/188409248.
| mode: ButtonPressMode) -> Type[ButtonPressHandler]: | ||
| """Get the appropriate handler constructor for the given button press mode.""" | ||
| mapping = { | ||
| ButtonPressMode.NOTHING: PreviewOnlyButtonPressHandler, |
| @@ -128,6 +135,15 @@ def schedule_to(self, | |||
| self.stimuli_timing = timing or [] | |||
| self.stimuli_colors = colors or [] | |||
|
|
|||
| @property | |||
There was a problem hiding this comment.
This property is also set on the task class?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added Inquiry Preview functionality for Matrix Calibration and Matrix Copy Phrase. Fixed a bug in RSVP Copy Phrase when using Inquiry Preview.
Ticket
https://www.pivotaltracker.com/story/show/188181571
Contributions
Test