Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saved Device Status #363

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Saved Device Status #363

merged 1 commit into from
Nov 13, 2024

Conversation

lawhead
Copy link
Collaborator

@lawhead lawhead commented Nov 8, 2024

Overview

Ensure that the device status configured in the parameters file overrides the preconfigured value in devices.json

Ticket

https://www.pivotaltracker.com/story/show/188529396

Contributions

  • Added unit tests for the acquisition helper module.
  • Slight refactor to make the initialization of the device status more testable.

Test

  • Ran all unit tests
  • Ran a sample calibration to ensure that the devices.json in the output folder had the expected values.

…rs file overrides the preconfigured value in devices.json
@lawhead lawhead requested a review from tab-cmd November 8, 2024 00:02
Copy link
Contributor

@tab-cmd tab-cmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll give this a proper try once @celikbasak 's code is in, and we are about ready to release the patch 👍🏼

@lawhead lawhead changed the base branch from main to 2.0.1rc4 November 13, 2024 00:11
@lawhead lawhead merged commit d1be1f9 into 2.0.1rc4 Nov 13, 2024
9 checks passed
@lawhead lawhead deleted the saved-device-status branch November 13, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants