Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in server description #18

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix typo in server description #18

merged 1 commit into from
Oct 23, 2023

Conversation

grugna
Copy link
Collaborator

@grugna grugna commented Oct 23, 2023

The description of the Treehouse server and the PCDC have been inverted.

Before submitting this PR, please make sure:

  • [X ] You have added a few sentences describing the PR here.
  • [X ] You have added yourself or the appropriate individual as the assignee.
  • [X ] You have added the relevant groups/individuals to the reviewers.
  • Your commit messages conform to the Conventional Commits standard.
  • You have updated the README or other documentation to account for these changes (when appropriate).

@grugna grugna self-assigned this Oct 23, 2023
claymcleod
claymcleod approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@claymcleod claymcleod left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I went ahead and updated the Rust code that generates this as well. You can merge in whenever the checks pass IMO.

@grugna grugna merged commit 70be967 into main Oct 23, 2023
5 checks passed
@grugna grugna deleted the fix_servers_description branch October 23, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claymcleod claymcleod claymcleod approved these changes

@hbeale hbeale Awaiting requested review from hbeale

@jingchunzhu jingchunzhu Awaiting requested review from jingchunzhu

@melissacline melissacline Awaiting requested review from melissacline

@kevin-benton kevin-benton Awaiting requested review from kevin-benton

Assignees

@grugna grugna

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grugna @claymcleod