Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo Refactory -> Refractory #23

Merged
merged 1 commit into from
Nov 16, 2023
Merged

fix: typo Refactory -> Refractory #23

merged 1 commit into from
Nov 16, 2023

Conversation

e-t-k
Copy link
Collaborator

@e-t-k e-t-k commented Nov 3, 2023

Typo. see Concept Code C38014 ( https://nciterms.nci.nih.gov/ncitbrowser/ConceptReport.jsp?dictionary=NCI_Thesaurus&code=C38014&ns=ncit )

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added the relevant groups/individuals to the reviewers.
  • Your commit messages conform to the Conventional Commits standard.
  • You have updated the README or other documentation to account for these changes (when appropriate).

@e-t-k e-t-k requested a review from claymcleod November 3, 2023 17:21
@e-t-k e-t-k self-assigned this Nov 3, 2023
@GeoffLyle
Copy link
Collaborator

Note that this typo (Refactory) is in the CDE itself (https://cadsr.cancer.gov/onedata/dmdirect/NIH/NCI/CO/CDEDD?filter=CDEDD.ITEM_ID=12217251%20and%20ver_nr=1).

I have brought this up the folks at the NIH and Leidos. Hopefully this gets corrected soon. I'm torn between using the 'correct' value ("Refractory") and what is currently in the CDE.

@claymcleod
Copy link
Collaborator

claymcleod commented Nov 4, 2023

Good catch! We discussed this in our meeting yesterday, and we decided to keep the misspelling for now—our goal is to match the CDE exactly. Once the CDE is updated (which is sounds like we are talking to them now to fix), I will accept this PR.

@claymcleod claymcleod added the api-bug Something isn't working label Nov 5, 2023
@GeoffLyle
Copy link
Collaborator

Not sure when the CDE was updated (couldn't find a change history in the 'Audit Trail' section of the CDE), but it looks like the typo has been fixed. The permissible value is now "Refractory" and the VM Long Name is also "Refractory".

Link to CDE 12217251: https://cadsr.cancer.gov/onedata/dmdirect/NIH/NCI/CO/CDEDD?filter=CDEDD.ITEM_ID=12217251%20and%20ver_nr=1

@claymcleod
Copy link
Collaborator

Great! We can merge in now @e-t-k

@e-t-k e-t-k merged commit 1ff2837 into main Nov 16, 2023
5 checks passed
@e-t-k e-t-k deleted the fix/refactory-typo branch November 16, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants