Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: Prettier Integration #262

Merged
merged 20 commits into from
Apr 3, 2024
Merged

DX: Prettier Integration #262

merged 20 commits into from
Apr 3, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Jan 12, 2024

Overview

This PR will focus on introducing the new Prettier integration and Eslint rule reconfiguring. After merging this PR, a separate PR will be created to FIX the linting issues. We'll do it separately to make it easy to revert if necessary.

Note

It may be necessary to manually run npm run prepare to initialize Husky if the repo is already cloned locally

To-Do

Action items for this PR:

  • Target PMVP M1 branch (no longer MVP-2 M3)
  • migrate workflow changes to separate files as needed (e.g. prettier separate)
  • Remove prop-types usage in layouts/index.tsx
  • Enforce double quotes? Prettier will enforce this
  • Do we want to enable no-use-before-define? Requires lots of manual fixes
  • Add base prettier config file

Action items after merging:

  • npm run lint:fix
  • Remove react-router import and replace with react-router-dom in router.tsx (see errors)
  • Fix use before define
  • Fix redundant type constituents
  • Fix unescaped entities
  • Fix unreachable code
  • 'react-transition-group' not listed in project deps
  • 'graphql-tag' not listed in project deps

Change Details (Specifics)

  • Setup Prettier w/Eslint integration
  • Setup Husky and precommit hook
  • Update project README.md with coverage badge and Husky info

Related Ticket(s)

N/A

@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label Jan 12, 2024
@amattu2 amattu2 added this to the MVP-2.2.0 (M4) milestone Jan 24, 2024
@amattu2 amattu2 changed the base branch from mvp-2.1.0 to 3.0.0 March 14, 2024 21:00
@amattu2 amattu2 changed the title Eslint + Prettier Integration DX: Prettier Integration Mar 15, 2024
@amattu2 amattu2 marked this pull request as ready for review March 28, 2024 14:22
amattu2 and others added 4 commits April 2, 2024 11:18
- Enforce arrow-function component definitions
- Enforce variable naming-convention
- Remove jsx-a11y anchor rule disabling
- Disable eslint indent and use typescript rule
- Also Remove typescript quotes and indents rules
@amattu2 amattu2 removed the 🚧 Do Not Merge This PR is not ready for merging label Apr 3, 2024
@amattu2
Copy link
Member Author

amattu2 commented Apr 3, 2024

Per discussion – Merging AS-IS and will address all of the issues in a separate PR. The 3.0.0 branch will be broken temporarily. Latest build stable frontend build is tagged at 3.0.0.292

@amattu2 amattu2 merged commit d51577c into 3.0.0 Apr 3, 2024
1 of 2 checks passed
@amattu2 amattu2 deleted the eslint-linting branch April 3, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants