-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DX: Prettier Integration #262
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enforce arrow-function component definitions - Enforce variable naming-convention - Remove jsx-a11y anchor rule disabling - Disable eslint indent and use typescript rule
- Also Remove typescript quotes and indents rules
Per discussion – Merging AS-IS and will address all of the issues in a separate PR. The 3.0.0 branch will be broken temporarily. Latest build stable frontend build is tagged at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR will focus on introducing the new Prettier integration and Eslint rule reconfiguring. After merging this PR, a separate PR will be created to FIX the linting issues. We'll do it separately to make it easy to revert if necessary.
Note
It may be necessary to manually run
npm run prepare
to initialize Husky if the repo is already cloned locallyTo-Do
Action items for this PR:
prop-types
usage inlayouts
/index.tsx
Enforce double quotes?Prettier will enforce thisno-use-before-define
? Requires lots of manual fixesAction items after merging:
npm run lint:fix
react-router
import and replace withreact-router-dom
in router.tsx (see errors)Change Details (Specifics)
Related Ticket(s)
N/A