Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle metric field per UX #525

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Restyle metric field per UX #525

merged 3 commits into from
Nov 8, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Nov 7, 2024

Overview

Minor UX updates to the Operation Dashboard metric dropdown.

Change Details (Specifics)

  • Restyle the Operation Dashboard page to remove negative margins for positioning
  • Adjust the dropdown and label styling per UX
  • Fix the QuickSight frame not rendering the rounded border

Related Ticket(s)

CRDCDH-1428 (Design task)

@amattu2 amattu2 added this to the 3.1.0 (PMVP-M2) milestone Nov 7, 2024
@coveralls
Copy link
Collaborator

coveralls commented Nov 7, 2024

Pull Request Test Coverage Report for Build 11749363410

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 53.813%

Totals Coverage Status
Change from base Build 11749350865: 0.004%
Covered Lines: 3722
Relevant Lines: 6430

💛 - Coveralls

@amattu2 amattu2 marked this pull request as ready for review November 8, 2024 14:22
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM! One minor change and one question.

@Alejandro-Vega Alejandro-Vega added the 📝 Change Requested This PR has requested changes label Nov 8, 2024
@amattu2 amattu2 removed the 📝 Change Requested This PR has requested changes label Nov 8, 2024
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't re-test but code LGTM!

@Alejandro-Vega Alejandro-Vega merged commit 573ba6a into 3.1.0 Nov 8, 2024
5 checks passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-1428 branch November 8, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants