Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-1976 Fix Node labels overlapping #526

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Nov 8, 2024

Overview

PR to apply truncation to the Individual Pie Chart labels after 14 characters. I tried a few different combinations and 14 characters seems reasonable, but if there's a number that visually looks better, LMK.

New vs. Old

Screenshot 2024-11-08 at 10 43 52 AM Screenshot 2024-11-08 at 10 43 13 AM

Change Details (Specifics)

  • Apply standard truncation when a node label exceeds 14 characters
  • Update how we handle label reformatting to try and closer-respect what the MDF dictates
  • Add test coverage for label handling

Related Ticket(s)

CRDCDH-1976

@amattu2 amattu2 added this to the 3.1.0 (PMVP-M2) milestone Nov 8, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11745532824

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 53.809%

Totals Coverage Status
Change from base Build 11693299715: 0.05%
Covered Lines: 3721
Relevant Lines: 6429

💛 - Coveralls

@amattu2 amattu2 changed the title fix: Node labels overlapping CRDCDH-1976 Fix Node labels overlapping Nov 8, 2024
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit aa06d99 into 3.1.0 Nov 8, 2024
7 checks passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-1976 branch November 8, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants