feat(legacy): chatcontrol module #4836
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pr will be on pending |
|
Progress? |
DataM0del
suggested changes
Jan 18, 2025
src/main/java/net/ccbluex/liquidbounce/injection/forge/mixins/gui/MixinGuiNewChat.java
Outdated
Show resolved
Hide resolved
| public String message; | ||
|
|
||
| @Inject(method = "<init>(Ljava/lang/String;)V", at = @At("RETURN"), cancellable = true) | ||
| public void injectForceUnicodeChat(String p_i45240_1_, CallbackInfo ci) { |
There was a problem hiding this comment.
Searge be like:
❌ map the parameter names
✔️ leave it there, happens 99.99% of the time.
Comment on lines
14
to
18
| val noChatClear by boolean("NoChatClear", true) | ||
| // TODO: Add stackMessage | ||
| val stackMessage by boolean("StackMessage", true) | ||
| val noLengthLimit by boolean("NoLengthLimit", true) | ||
| val forceUnicodeChat by boolean("ForceUnicodeChat", false) |
There was a problem hiding this comment.
Add a ToggleableConfigurable object like in Nextgen so the module settings aren't cluttered, and use that here for the settings for each of these.
|
add second chat pleas
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
valuex]Closes: #4243