Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve CrystalAura #5383

Open
wants to merge 29 commits into
base: nextgen
Choose a base branch
from

Conversation

ccetl
Copy link
Contributor

@ccetl ccetl commented Jan 20, 2025

  • makes the crystal aura multi threaded
  • makes the crystal aura event based
  • introduces additional settings, fixes and improvements

@ccetl ccetl mentioned this pull request Jan 20, 2025
12 tasks
@LTBlueLatios
Copy link
Contributor

Crystal Aura wasn't event-based originally? 💀

@ccetl ccetl marked this pull request as ready for review January 26, 2025 11:37
@ccetl
Copy link
Contributor Author

ccetl commented Jan 26, 2025

Currently there is one issue: the rotations are sometimes mirrored.

@ccetl ccetl marked this pull request as draft January 26, 2025 22:51
@ccetl ccetl marked this pull request as ready for review January 27, 2025 20:55
@ccetl ccetl requested a review from 1zun4 January 27, 2025 20:55
@ccetl ccetl marked this pull request as draft January 27, 2025 21:32
@ccetl
Copy link
Contributor Author

ccetl commented Jan 27, 2025

I'll refactor that

@ccetl ccetl marked this pull request as ready for review January 28, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants