feat: Auto Rod #5419
feat: Auto Rod #5419
Conversation
There was a problem hiding this comment.
Remove this. Use Chronometer.
| return -1 | ||
| } | ||
|
|
||
| private fun getAllNearbyEnemies(): List<Entity?>? { |
| /** | ||
| * Find rod in inventory | ||
| */ | ||
| private fun findRod(startSlot: Int, endSlot: Int): Int { | ||
| for (i in startSlot until endSlot) { | ||
| val stack = mc.player?.inventory?.getStack(i) | ||
| if (stack != null && stack.item == Items.FISHING_ROD) { | ||
| return i | ||
| } | ||
| } | ||
| return -1 | ||
| } |
There was a problem hiding this comment.
Slots.Hotbar.findSlotIndex(Items.FISHING_ROD)
|
|
||
| init { | ||
|
|
||
|
|
|
|
||
| object ModuleAutoRod : ClientModule("AutoRod", Category.COMBAT) { | ||
|
|
||
| object facingEnemy : ToggleableConfigurable(this, "FacingEnemy", true) { |
There was a problem hiding this comment.
"FacingEnemy" - Follow Kotlin Naming Convention
|
|
||
| object facingEnemy : ToggleableConfigurable(this, "FacingEnemy", true) { | ||
|
|
||
| object ignoreOnEnemyLowHealth : ToggleableConfigurable(this, "IgnoreOnEnemyLowHealth", true) { |
There was a problem hiding this comment.
IgnoreOnEnemyLowHealth same here with Naming Convention.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| } | ||
| } | ||
| } else mc.player?.health?.let { it1 -> |
Check warning
Code scanning / detekt
Braces do not comply with the specified policy Warning
| private val pushTimer = Chronometer() | ||
| private val rodPullTimer = Chronometer() | ||
| private var rodInUse = false | ||
| private var switchBack: Int? = -1 |
There was a problem hiding this comment.
Type of Int? is not required to be defined in this case.
| private val pushDelay by int("PushDelay", 100, 50..1000) | ||
| private val pullbackDelay by int("PullbackDelay", 500, 50..1000) |
| val tickHandler = tickHandler { | ||
| // Check if player is using rod | ||
| val usingRod = | ||
| (mc.player?.isUsingItem == true && mc.player?.mainHandStack?.item == Items.FISHING_ROD) || rodInUse |
There was a problem hiding this comment.
mc.player.isUsingItem can be replaced with player.isUsingItem
| (mc.player?.isUsingItem == true && mc.player?.mainHandStack?.item == Items.FISHING_ROD) || rodInUse | |
| (player.isUsingItem && player.mainHandStack.item == Items.FISHING_ROD) || rodInUse |
|
|
||
| } else { | ||
| // Stop using rod | ||
| mc.player?.stopUsingItem() |
There was a problem hiding this comment.
| mc.player?.stopUsingItem() | |
| player.stopUsingItem() |
| var facingEntity = mc.targetedEntity | ||
| if (facingEntity == null) { | ||
|
|
||
| var finaltarget: Entity? = null |
There was a problem hiding this comment.
finaltarget does not follow Kotlin Naming Convention as well - should be finalTarget instead.
| if(finaltarget == null){ | ||
| return@tickHandler | ||
| } |
There was a problem hiding this comment.
| if(finaltarget == null){ | |
| return@tickHandler | |
| } | |
| if(finaltarget == null) { | |
| return@tickHandler | |
| } |
|
|
||
| if (rod && pushTimer.hasElapsed(pushDelay.toLong())) { | ||
| // Check if player has rod in hand | ||
| if (mc.player?.mainHandStack != Items.FISHING_ROD) { |
There was a problem hiding this comment.
| if (mc.player?.mainHandStack != Items.FISHING_ROD) { | |
| if (player.mainHandStack != Items.FISHING_ROD) { |
| return@tickHandler | ||
| } | ||
| // Switch to rod | ||
| switchBack = mc.player?.inventory?.getSlotWithStack(mc.player?.inventory?.mainHandStack) |
There was a problem hiding this comment.
| switchBack = mc.player?.inventory?.getSlotWithStack(mc.player?.inventory?.mainHandStack) | |
| switchBack = player.inventory.getSlotWithStack(player.inventory.mainHandStack) |
| if (rod == null) { | ||
| return | ||
| } | ||
| mc.player?.inventory?.selectedSlot = rod |
There was a problem hiding this comment.
We do not change the selected slot like that in LiquidBounce Nextgen. LiquidBounce Nextgen offers a much util for that instead called SilentHotbar.
| } | ||
| mc.player?.inventory?.selectedSlot = rod | ||
| // We do not need to send our own packet, because sendUseItem will handle it for us. | ||
| KeyBinding.setKeyPressed(mc.options.useKey.boundKey, true) |
There was a problem hiding this comment.
We do not set key press states in LiquidBounce Nextgen like that. It should rather use the KeybindIsPressedEvent instead.
|
@1zun4 modified,but I have no idea about using KeybindIsPressedEvent and make it work.So I keep it as it. |
|
|
||
|
|
| private val pushTimer = Chronometer() | ||
| private val rodPullTimer = Chronometer() | ||
| private var rodInUse = false | ||
| private var switchBack: Int = -1 |
There was a problem hiding this comment.
| private var switchBack: Int = -1 | |
| private var switchBack = -1 |
| val enemyHealthThreshold by int( | ||
| "EnemyHealthThreshold", 5, 1..20 | ||
| ) |
There was a problem hiding this comment.
| val enemyHealthThreshold by int( | |
| "EnemyHealthThreshold", 5, 1..20 | |
| ) | |
| val enemyHealthThreshold by int("EnemyHealthThreshold", 5, 1..20) |
| object ModuleAutoRod : ClientModule("AutoRod", Category.COMBAT) { | ||
|
|
||
| object FacingEnemy : ToggleableConfigurable(this, "FacingEnemy", true) { | ||
|
|
|
|
||
|
|
||
| object ModuleAutoRod : ClientModule("AutoRod", Category.COMBAT) { | ||
|
|
| val rod = Slots.Hotbar.findSlot(Items.FISHING_ROD)?.hotbarSlot | ||
| if (rod == null) { | ||
| // There is no rod in hotbar | ||
| return@tickHandler | ||
| } | ||
| // Switch to rod | ||
|
|
||
|
|
There was a problem hiding this comment.
| val rod = Slots.Hotbar.findSlot(Items.FISHING_ROD)?.hotbarSlot | |
| if (rod == null) { | |
| // There is no rod in hotbar | |
| return@tickHandler | |
| } | |
| // Switch to rod | |
| val rod = Slots.Hotbar.findSlot(Items.FISHING_ROD)?.hotbarSlot ?: return@tickHandler | |
| // Switch to rod |
| val usingRod = | ||
| (player.isUsingItem == true && player.mainHandStack?.item == Items.FISHING_ROD) || rodInUse |
There was a problem hiding this comment.
| val usingRod = | |
| (player.isUsingItem == true && player.mainHandStack?.item == Items.FISHING_ROD) || rodInUse | |
| val usingRod = player.isUsingItem && player.mainHandStack?.item == Items.FISHING_ROD || rodInUse |
| // Switch back to previous item | ||
| player.inventory?.selectedSlot = switchBack!! | ||
| interaction.syncSelectedSlot() | ||
|
|
| if (usingRod) { | ||
| // Check if rod pull timer has reached delay | ||
| // mc.player.fishEntity?.caughtEntity != null is always null | ||
|
|
| } else { | ||
| var rod = false | ||
|
|
||
| if (FacingEnemy.enabled && player.getActualHealth()!! >= IgnoreOnEnemyLowHealth.playerHealthThreshold) { |
There was a problem hiding this comment.
| if (FacingEnemy.enabled && player.getActualHealth()!! >= IgnoreOnEnemyLowHealth.playerHealthThreshold) { | |
| if (FacingEnemy.enabled && player.getActualHealth() >= IgnoreOnEnemyLowHealth.playerHealthThreshold) { |
any reason you're using getActualHealth here?
| return@tickHandler | ||
| } | ||
| finalTarget.distanceTo(player).let { it1 -> | ||
| if (it1 > range || it1 < ModuleKillAura.range && ModuleKillAura.enabled) { |
There was a problem hiding this comment.
why are you using killaura range?
| (player.isUsingItem) || | ||
| KillAuraAutoBlock.blockVisual |
There was a problem hiding this comment.
| (player.isUsingItem) || | |
| KillAuraAutoBlock.blockVisual | |
| player.isUsingItem || KillAuraAutoBlock.blockVisual |
| // Check if the enemy's health is below the threshold. | ||
| if (IgnoreOnEnemyLowHealth.enabled) { | ||
| if ((facingEntity is LivingEntity) && | ||
| facingEntity.health >= IgnoreOnEnemyLowHealth.enemyHealthThreshold |
There was a problem hiding this comment.
use getActualHealth() for other entities
| var finalTarget: Entity? = null | ||
| finalTarget = targetTracker.lockedOnTarget | ||
| if(finalTarget == null) { | ||
| return@tickHandler | ||
| } |
There was a problem hiding this comment.
| var finalTarget: Entity? = null | |
| finalTarget = targetTracker.lockedOnTarget | |
| if(finalTarget == null) { | |
| return@tickHandler | |
| } | |
| val finalTarget = targetTracker.lockedOnTarget ?: return@tickHandler |
The branch carried AutoRod from legacy to nextgen.