Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Update Rust and fix windows build #1480

Merged
merged 59 commits into from
Mar 12, 2023
Merged

[IMPROVEMENT] Update Rust and fix windows build #1480

merged 59 commits into from
Mar 12, 2023

Conversation

prateekmedia
Copy link
Member

@prateekmedia prateekmedia commented Feb 16, 2023 •
edited
Loading

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.
  • Update Rust to stable (done)
  • Switch to rusty_ffmpeg and rsmpeg from ffmpeg-sys-next
  • Fix windows CI (add support of vcpkg for static linking and supporting both architectures)

@prateekmedia prateekmedia marked this pull request as draft February 16, 2023 11:30
@prateekmedia prateekmedia force-pushed the patch-1 branch 12 times, most recently from 8a5338b to 9b513a0 Compare February 25, 2023 14:49
@prateekmedia prateekmedia changed the title fix: windows build Update Rust and fix windows build Mar 1, 2023
@prateekmedia prateekmedia marked this pull request as ready for review March 1, 2023 15:45
@prateekmedia prateekmedia force-pushed the patch-1 branch 2 times, most recently from 2116d79 to 4729a71 Compare March 1, 2023 16:19
@prateekmedia prateekmedia mentioned this pull request Mar 8, 2023
Merged
@prateekmedia prateekmedia force-pushed the patch-1 branch 9 times, most recently from 1cb8d7c to af4a4d4 Compare March 10, 2023 16:23
@prateekmedia prateekmedia changed the title Update Rust and fix windows build [Improvement] Update Rust and fix windows build Mar 12, 2023
@prateekmedia prateekmedia changed the title [Improvement] Update Rust and fix windows build [IMPROVEMENT] Update Rust and fix windows build Mar 12, 2023
@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 0/13
CEA-708 0/14
DVB 0/7
DVD 0/3
DVR-MS 0/2
General 0/27
Hauppage 0/3
MP4 0/3
NoCC 0/10
Options 0/87
Teletext 0/21
WTV 0/13
XDS 0/34

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@prateekmedia
Copy link
Member Author

The test results doesn't look good, 0 passed out of them.

@cfsmp3
Copy link
Contributor

cfsmp3 commented Mar 12, 2023

The test results doesn't look good, 0 passed out of them.

I suspect the CI, but @canihavesomecoffee will have to confirm what's going on :-)

@prateekmedia
Copy link
Member Author

prateekmedia commented Mar 12, 2023 •
edited
Loading

I checked the ccextractorwinfull.exe and It couldn't find the eng.traineddata file for hardsubx, I see that vcpkg doesn't include that by default so we would have to copy that in the PostBuildScript of vccxproj. But the problem is that I am not sure if It will be able to find the eng.traineddata path even after bundling it in the exe at some location.

@cfsmp3
Copy link
Contributor

cfsmp3 commented Mar 12, 2023

I checked the ccextractorwinfull.exe and It couldn't find the eng.traineddata file for hardsubx, I see that vcpkg doesn't include that by default so we would have to copy that in the PostBuildScript of vccxproj. But the problem is that I am not sure if It will be able to find the eng.traineddata path even after bundling it in the exe at some location.

We should be able to just wget it from the github action itself ( https://github.com/tesseract-ocr/tessdata/raw/main/eng.traineddata )

And then use it.

@cfsmp3 cfsmp3 merged commit 0264e7d into CCExtractor:master Mar 12, 2023
This was referenced Mar 14, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prateekmedia @ccextractor-bot @cfsmp3