feat: make taskchampion view stateless

CCExtractor · Jul 6, 2024 · 16722bf · 16722bf
1 parent 1d09d36
commit 16722bf
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 41 deletions.
diff --git a/lib/app/modules/home/views/home_page_app_bar.dart b/lib/app/modules/home/views/home_page_app_bar.dart
@@ -107,8 +107,7 @@ class HomePageAppBar extends StatelessWidget implements PreferredSizeWidget {
                             Navigator.push(
                                 context,
                                 MaterialPageRoute(
-                                  builder: (_) =>
-                                      const ManageTaskChampionCreds(),
+                                  builder: (_) => ManageTaskChampionCreds(),
                                 )).then((value) {});
                           },
                           textColor: TaskWarriorColors.purple,
@@ -144,7 +143,7 @@ class HomePageAppBar extends StatelessWidget implements PreferredSizeWidget {
                           Navigator.push(
                               context,
                               MaterialPageRoute(
-                                builder: (_) => const ManageTaskChampionCreds(),
+                                builder: (_) => ManageTaskChampionCreds(),
                               )).then((value) {});
                         },
                         textColor: TaskWarriorColors.purple,

diff --git a/lib/app/modules/home/views/nav_drawer.dart b/lib/app/modules/home/views/nav_drawer.dart
@@ -96,7 +96,7 @@ class NavDrawer extends StatelessWidget {
                 onTap: () {
                   Navigator.of(context).push(
                     MaterialPageRoute(
-                      builder: (context) => const ManageTaskChampionCreds(),
+                      builder: (context) => ManageTaskChampionCreds(),
                     ),
                   );
                 },

diff --git a/lib/app/utils/taskchampion/taskchampion.dart b/lib/app/utils/taskchampion/taskchampion.dart
@@ -6,49 +6,29 @@ import 'package:taskwarrior/app/utils/constants/taskwarrior_fonts.dart';
 import 'package:taskwarrior/app/utils/theme/app_settings.dart';
 import 'package:url_launcher/url_launcher.dart';
 
-class ManageTaskChampionCreds extends StatefulWidget {
-  const ManageTaskChampionCreds({super.key});
-
-  @override
-  State<ManageTaskChampionCreds> createState() =>
-      _ManageTaskChampionCredsState();
-}
-
-class _ManageTaskChampionCredsState extends State<ManageTaskChampionCreds> {
-  String encryptionSecret = '';
-  String clientId = '';
-
+class ManageTaskChampionCreds extends StatelessWidget {
   final TextEditingController _encryptionSecretController =
       TextEditingController();
   final TextEditingController _clientIdController = TextEditingController();
 
-  @override
-  void initState() {
-    super.initState();
+  ManageTaskChampionCreds({super.key}) {
     _loadCredentials();
   }
 
   Future<void> _loadCredentials() async {
     SharedPreferences prefs = await SharedPreferences.getInstance();
-    setState(() {
-      encryptionSecret = prefs.getString('encryptionSecret') ?? '';
-      clientId = prefs.getString('clientId') ?? '';
-      _encryptionSecretController.text = encryptionSecret;
-      _clientIdController.text = clientId;
-    });
+    _encryptionSecretController.text =
+        prefs.getString('encryptionSecret') ?? '';
+    _clientIdController.text = prefs.getString('clientId') ?? '';
   }
 
-  Future<void> _saveCredentials() async {
+  Future<void> _saveCredentials(BuildContext context) async {
     SharedPreferences prefs = await SharedPreferences.getInstance();
     await prefs.setString('encryptionSecret', _encryptionSecretController.text);
     await prefs.setString('clientId', _clientIdController.text);
-  }
-
-  @override
-  void dispose() {
-    _encryptionSecretController.dispose();
-    _clientIdController.dispose();
-    super.dispose();
+    ScaffoldMessenger.of(context).showSnackBar(
+      const SnackBar(content: Text('Credentials saved successfully')),
+    );
   }
 
   @override
@@ -136,14 +116,7 @@ class _ManageTaskChampionCredsState extends State<ManageTaskChampionCreds> {
                   ),
                   const SizedBox(height: 20),
                   ElevatedButton(
-                    onPressed: () async {
-                      await _saveCredentials();
-                      // ignore: use_build_context_synchronously
-                      ScaffoldMessenger.of(context).showSnackBar(
-                        const SnackBar(
-                            content: Text('Credentials saved successfully')),
-                      );
-                    },
+                    onPressed: () => _saveCredentials(context),
                     child: const Text('Save Credentials'),
                   ),
                   const SizedBox(height: 10),